[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu May 23 02:38:16 PDT 2024
================
@@ -321,6 +321,11 @@ class ELFFile {
std::vector<Elf_Rel> decode_relrs(Elf_Relr_Range relrs) const;
+ uint64_t crelHeader(ArrayRef<uint8_t> Content) const;
----------------
jh7370 wrote:
It's not clear without looking at the method definition what the return value actually represents. Indeed, this method name doesn't seem to conform to the LLVM naming guidelines, since it's neither a verb or adjective phrase or similar. Perhaps renaming the method would be wise (and also possibly a comment to explain it, if needed still after the renaming).
https://github.com/llvm/llvm-project/pull/91280
More information about the llvm-commits
mailing list