[llvm] [WindowsManifestMerger] Remove deprecated call to xmlKeepBlanksDefault (PR #93139)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed May 22 22:52:47 PDT 2024


https://github.com/nikic created https://github.com/llvm/llvm-project/pull/93139

This function has been deprecated in favor of the XML_PARSE_NOBLANKS option. The code already uses the option, so remove the call. If this call served some additional purpose, then it wasn't tested.

>From db39b9dcff0d4392b072ecb7518b40adfa2bc0e4 Mon Sep 17 00:00:00 2001
From: Nikita Popov <npopov at redhat.com>
Date: Thu, 23 May 2024 07:47:13 +0200
Subject: [PATCH] [WindowsManifestMerger] Remove deprecated call to
 xmlKeepBlanksDefault

This function has been deprecated in favor of the XML_PARSE_NOBLANKS
option. The code already uses the option, so remove the call. If
this call served some additional purpose, then it wasn't tested.
---
 llvm/lib/WindowsManifest/WindowsManifestMerger.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp b/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
index 8f5c53faf91e2..b59b666ce04f9 100644
--- a/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
+++ b/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
@@ -669,7 +669,6 @@ WindowsManifestMerger::WindowsManifestMergerImpl::getMergedManifest() {
     xmlDocSetRootElement(OutputDoc.get(), CombinedRoot);
     assert(nullptr == xmlDocGetRootElement(CombinedDoc));
 
-    xmlKeepBlanksDefault(0);
     xmlChar *Buff = nullptr;
     xmlDocDumpFormatMemoryEnc(OutputDoc.get(), &Buff, &BufferSize, "UTF-8", 1);
     Buffer.reset(Buff);



More information about the llvm-commits mailing list