[compiler-rt] [compiler-rt][ASan] Add function moving annotations (PR #91702)

via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 19:10:31 PDT 2024


AdvenamTacet wrote:

I still have to fix failing CI, I can sit to it on Monday and, if necessary, spend next week enough of time to fix it. I expect the problem to be a small implementation bug. Let me know if you have any high level requests for that code, I'm happy to implement them.
I will also create a separate PR cleaning compiler-rt ASan code, as I noticed a little bit of outdated code while writing this one.

> trivial relocation is also interesting for erasing object from a vector, so the builtins should probably be more akin to a memmove than a memcpy.

Should we change `__builtin_memcpy` to `__builtin_memmove`? Then I would have to add support for overlapping areas to this PR. (It complicates the implementation a little bit.)

> It's probably fine, but I'd like to think about this more.

Sure, let me know what are your conclusions!

https://github.com/llvm/llvm-project/pull/91702


More information about the llvm-commits mailing list