[llvm] [BOLT][NFC] Eliminate uses of throwing std::map::at (PR #92950)

[Amir Ayupov via llvm-commits]

================
@@ -1553,36 +1553,28 @@ Error PrintProgramStats::runOnFunctions(BinaryContext &BC) {
     const bool Ascending =
         opts::DynoStatsSortOrderOpt == opts::DynoStatsSortOrder::Ascending;
 
-    if (SortAll) {
-      llvm::stable_sort(Functions,
-                        [Ascending, &Stats](const BinaryFunction *A,
-                                            const BinaryFunction *B) {
-                          auto StatsItr = Stats.find(A);
-                          assert(StatsItr != Stats.end());
-                          const DynoStats &StatsA = StatsItr->second;
-
-                          StatsItr = Stats.find(B);
-                          assert(StatsItr != Stats.end());
-                          const DynoStats &StatsB = StatsItr->second;
-
-                          return Ascending ? StatsA < StatsB : StatsB < StatsA;
-                        });
-    } else {
-      llvm::stable_sort(
-          Functions, [Ascending, &Stats](const BinaryFunction *A,
-                                         const BinaryFunction *B) {
-            auto StatsItr = Stats.find(A);
-            assert(StatsItr != Stats.end());
-            const DynoStats &StatsA = StatsItr->second;
-
-            StatsItr = Stats.find(B);
-            assert(StatsItr != Stats.end());
-            const DynoStats &StatsB = StatsItr->second;
-
-            return Ascending ? StatsA.lessThan(StatsB, opts::PrintSortedBy)
-                             : StatsB.lessThan(StatsA, opts::PrintSortedBy);
-          });
-    }
+    std::function<bool(const DynoStats &, const DynoStats &)>
+        DynoStatsComparator =
+            SortAll ? [](const DynoStats &StatsA,
----------------
aaupov wrote:

Please sink SortAll down further

https://github.com/llvm/llvm-project/pull/92950