[llvm] [BOLT] [NFC] Eliminate uses of throwing std::map::at (PR #92950)

via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 11:51:53 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7847b1ca00fb4649799125592f01cd38c5509b45 95fdd32abaf6d41b5c6bad66deb2033d40cdc048 -- bolt/include/bolt/Profile/BoltAddressTranslation.h bolt/lib/Core/BinaryContext.cpp bolt/lib/Core/BinaryEmitter.cpp bolt/lib/Core/DynoStats.cpp bolt/lib/Passes/BinaryFunctionCallGraph.cpp bolt/lib/Passes/BinaryPasses.cpp bolt/lib/Passes/CacheMetrics.cpp bolt/lib/Passes/Inliner.cpp bolt/lib/Profile/StaleProfileMatching.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/bolt/lib/Core/BinaryContext.cpp b/bolt/lib/Core/BinaryContext.cpp
index 046c5a3c0d..494a09c933 100644
--- a/bolt/lib/Core/BinaryContext.cpp
+++ b/bolt/lib/Core/BinaryContext.cpp
@@ -935,8 +935,8 @@ std::string BinaryContext::generateJumpTableName(const BinaryFunction &BF,
   if (const JumpTable *JT = BF.getJumpTableContainingAddress(Address)) {
     Offset = Address - JT->getAddress();
     auto JTLabelsIt = JT->Labels.find(Offset);
-    if ( JTLabelsIt != JT->Labels.end())
-      return std::string(JTLabelsIt ->second->getName());
+    if (JTLabelsIt != JT->Labels.end())
+      return std::string(JTLabelsIt->second->getName());
 
     auto JTIdsIt = JumpTableIds.find(JT->getAddress());
     assert(JTIdsIt != JumpTableIds.end());
diff --git a/bolt/lib/Passes/BinaryPasses.cpp b/bolt/lib/Passes/BinaryPasses.cpp
index 96a9a4c92b..e38dbbce61 100644
--- a/bolt/lib/Passes/BinaryPasses.cpp
+++ b/bolt/lib/Passes/BinaryPasses.cpp
@@ -1565,8 +1565,7 @@ Error PrintProgramStats::runOnFunctions(BinaryContext &BC) {
                           assert(StatsItr != Stats.end());
                           const DynoStats &StatsB = StatsItr->second;
 
-                          return Ascending ? StatsA < StatsB
-                                           : StatsB < StatsA;
+                          return Ascending ? StatsA < StatsB : StatsB < StatsA;
                         });
     } else {
       llvm::stable_sort(
diff --git a/bolt/lib/Passes/CacheMetrics.cpp b/bolt/lib/Passes/CacheMetrics.cpp
index 7c710156c8..21b420a5c2 100644
--- a/bolt/lib/Passes/CacheMetrics.cpp
+++ b/bolt/lib/Passes/CacheMetrics.cpp
@@ -164,8 +164,7 @@ double expectedCacheHitRatio(
       continue;
     auto BBAddrIt = BBAddr.find(BF->getLayout().block_front());
     assert(BBAddrIt != BBAddr.end());
-    const uint64_t Page =
-        BBAddrIt->second / ITLBPageSize;
+    const uint64_t Page = BBAddrIt->second / ITLBPageSize;
 
     auto FunctionSamplesIt = FunctionSamples.find(BF);
     assert(FunctionSamplesIt != FunctionSamples.end());
@@ -184,8 +183,7 @@ double expectedCacheHitRatio(
 
     auto BBAddrIt = BBAddr.find(BF->getLayout().block_front());
     assert(BBAddrIt != BBAddr.end());
-    const uint64_t Page =
-        BBAddrIt->second / ITLBPageSize;
+    const uint64_t Page = BBAddrIt->second / ITLBPageSize;
     // The probability that the page is not present in the cache
     const double MissProb =
         pow(1.0 - PageSamples[Page] / TotalSamples, ITLBEntries);
@@ -196,8 +194,7 @@ double expectedCacheHitRatio(
 
       BBAddrIt = BBAddr.find(SrcFunction->getLayout().block_front());
       assert(BBAddrIt != BBAddr.end());
-      const uint64_t SrcPage =
-          BBAddrIt->second / ITLBPageSize;
+      const uint64_t SrcPage = BBAddrIt->second / ITLBPageSize;
       // Is this a 'long' or a 'short' call?
       if (Page != SrcPage) {
         // This is a miss

``````````

</details>


https://github.com/llvm/llvm-project/pull/92950


More information about the llvm-commits mailing list