[llvm] [mlir] [MLIR][Analysis] Consolidate topological sort utilities (PR #92563)

[Tobias Gysi via llvm-commits]

================
@@ -107,14 +108,19 @@ computeDestructuringInfo(DestructurableMemorySlot &slot,
 
     // An operation that has blocking uses must be promoted. If it is not
     // promotable, destructuring must fail.
-    if (!promotable)
+    if (!promotable) {
+      // user->emitError() << "not promotable";
----------------
gysit wrote:

```suggestion
      // user->emitError() << "not promotable";
```
This and the change below look like debug leftovers?

https://github.com/llvm/llvm-project/pull/92563