[llvm] [BOLT] Tidy up code (PR #92927)

[Heewon Cho via llvm-commits]

https://github.com/Pribess updated https://github.com/llvm/llvm-project/pull/92927

>From 478f2269122be8c6a6dbb48962b60c3b9e1ca1c1 Mon Sep 17 00:00:00 2001
From: Heewon Cho <heewon6752 at gmail.com>
Date: Tue, 21 May 2024 21:52:25 +0900
Subject: [PATCH 1/3] [BOLT] Use const reference in range-based for loop

---
 bolt/include/bolt/Passes/StokeInfo.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bolt/include/bolt/Passes/StokeInfo.h b/bolt/include/bolt/Passes/StokeInfo.h
index 76417e6a2c3ba..a18c2a05d0153 100644
--- a/bolt/include/bolt/Passes/StokeInfo.h
+++ b/bolt/include/bolt/Passes/StokeInfo.h
@@ -87,10 +87,10 @@ struct StokeFuncInfo {
               << "," << NumBlocks << "," << IsLoopFree << "," << NumLoops << ","
               << MaxLoopDepth << "," << HotSize << "," << TotalSize << ","
               << Score << "," << HasCall << ",\"{ ";
-      for (std::string S : DefIn)
+      for (const std::string &S : DefIn)
         Outfile << "%" << S << " ";
       Outfile << "}\",\"{ ";
-      for (std::string S : LiveOut)
+      for (const std::string &S : LiveOut)
         Outfile << "%" << S << " ";
       Outfile << "}\"," << HeapOut << "," << StackOut << "," << HasRipAddr
               << "," << Omitted << "\n";

>From ab486e120cd75b28ca5d911a5126602508543995 Mon Sep 17 00:00:00 2001
From: Heewon Cho <heewon6752 at gmail.com>
Date: Wed, 22 May 2024 00:47:58 +0900
Subject: [PATCH 2/3] [BOLT] Remove dead initialization code

---
 bolt/runtime/hugify.cpp | 1 -
 bolt/runtime/instr.cpp  | 4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/bolt/runtime/hugify.cpp b/bolt/runtime/hugify.cpp
index 05c1be4f2d70c..65a21716b4e21 100644
--- a/bolt/runtime/hugify.cpp
+++ b/bolt/runtime/hugify.cpp
@@ -36,7 +36,6 @@ static void getKernelVersion(uint32_t *Val) {
   // release should be in the format: %d.%d.%d
   // major, minor, release
   struct UtsNameTy UtsName;
-  int Ret = __uname(&UtsName);
   const char *Buf = UtsName.release;
   const char *End = Buf + strLen(Buf);
   const char Delims[2][2] = {".", "."};
diff --git a/bolt/runtime/instr.cpp b/bolt/runtime/instr.cpp
index 16e0bbd55f90b..d1f8a216badcf 100644
--- a/bolt/runtime/instr.cpp
+++ b/bolt/runtime/instr.cpp
@@ -1245,7 +1245,6 @@ void Graph::computeEdgeFrequencies(const uint64_t *Counters,
       continue;
 
     assert(SpanningTreeNodes[Cur].NumInEdges == 1, "must have 1 parent");
-    const uint32_t Parent = SpanningTreeNodes[Cur].InEdges[0].Node;
     const uint32_t ParentEdge = SpanningTreeNodes[Cur].InEdges[0].ID;
 
     // Calculate parent edge freq.
@@ -1464,9 +1463,8 @@ void visitCallFlowEntry(CallFlowHashTable::MapEntry &Entry, int FD,
 int openProfile() {
   // Build the profile name string by appending our PID
   char Buf[BufSize];
-  char *Ptr = Buf;
   uint64_t PID = __getpid();
-  Ptr = strCopy(Buf, __bolt_instr_filename, BufSize);
+  char *Ptr = strCopy(Buf, __bolt_instr_filename, BufSize);
   if (__bolt_instr_use_pid) {
     Ptr = strCopy(Ptr, ".", BufSize - (Ptr - Buf + 1));
     Ptr = intToStr(Ptr, PID, 10);

>From e048f97c62ab221f5c37b0ab88fc5dfccaa463ce Mon Sep 17 00:00:00 2001
From: Heewon Cho <heewon6752 at gmail.com>
Date: Wed, 22 May 2024 01:07:10 +0900
Subject: [PATCH 3/3] [BOLT] Update hugify.cpp

---
 bolt/runtime/hugify.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bolt/runtime/hugify.cpp b/bolt/runtime/hugify.cpp
index 65a21716b4e21..05c1be4f2d70c 100644
--- a/bolt/runtime/hugify.cpp
+++ b/bolt/runtime/hugify.cpp
@@ -36,6 +36,7 @@ static void getKernelVersion(uint32_t *Val) {
   // release should be in the format: %d.%d.%d
   // major, minor, release
   struct UtsNameTy UtsName;
+  int Ret = __uname(&UtsName);
   const char *Buf = UtsName.release;
   const char *End = Buf + strLen(Buf);
   const char Delims[2][2] = {".", "."};