[llvm] [FileCheck] forbid filecheck prefix to end with directive name (PR #92735)

Paul T Robinson via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 08:20:45 PDT 2024


================
@@ -12,11 +12,11 @@ RUN:   FileCheck -check-prefix=CHECK1 %s
 CHECK1: .chk:1:18: remark: CHECK: expected string found in input
 CHECK1: .chk:2:17: remark: CHECK: expected string found in input
 
-# But we can define them as comment prefixes.
+# But we can define them as comment prefixes; still forbidden.
 
 RUN: %ProtectFileCheckOutput \
 RUN: FileCheck -dump-input=never -vv -comment-prefixes=COM,RUN,RUN-NOT %t.chk < %t.in 2>&1 | \
 RUN:   FileCheck -check-prefix=CHECK2 %s
 
-CHECK2: .chk:1:18: remark: CHECK: expected string found in input
+CHECK2: error: supplied comment prefix must not end with directive: '-NOT', prefix: 'RUN-NOT'
----------------
pogo59 wrote:

The FileCheck documentation specifically says that suffixes on a comment prefix are allowed. There should be no changes to this test.

https://github.com/llvm/llvm-project/pull/92735


More information about the llvm-commits mailing list