[llvm] [AMDGPU] Remove #if 0 code for indexed resources in SIInsertWaitcnts (PR #92905)
via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 05:33:20 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Jay Foad (jayfoad)
<details>
<summary>Changes</summary>
I do not understand what optimization this was supposed to implement.
It has never been enabled. I suspect it no longer applies to GCN/RDNA
architectures.
---
Full diff: https://github.com/llvm/llvm-project/pull/92905.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp (-11)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
index 5577ce9eb1282..ea694ddff4f3c 100644
--- a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
+++ b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
@@ -2309,17 +2309,6 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction &MF,
updateEventWaitcntAfter(Inst, &ScoreBrackets);
-#if 0 // TODO: implement resource type check controlled by options with ub = LB.
- // If this instruction generates a S_SETVSKIP because it is an
- // indexed resource, and we are on Tahiti, then it will also force
- // an S_WAITCNT vmcnt(0)
- if (RequireCheckResourceType(Inst, context)) {
- // Force the score to as if an S_WAITCNT vmcnt(0) is emitted.
- ScoreBrackets->setScoreLB(LOAD_CNT,
- ScoreBrackets->getScoreUB(LOAD_CNT));
- }
-#endif
-
if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) {
AMDGPU::Waitcnt Wait = WCG->getAllZeroWaitcnt(
Inst.mayStore() && !SIInstrInfo::isAtomicRet(Inst));
``````````
</details>
https://github.com/llvm/llvm-project/pull/92905
More information about the llvm-commits
mailing list