[llvm] [llvm-readobj] Fixes malformed json on JSON printed corefiles (PR #92835)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 00:30:36 PDT 2024
https://github.com/jh7370 commented:
Rather than adding a near-duplicate method to work around the fact that the existing code doesn't do what we need it to for JSON output, could we instead simply change the existing code to produce output that is valid (i.e. replace the existing function with the new one you've written)? It would mean that the LLVM output would change, but I don't think this is an issue: as far as I'm aware, we don't promise full output compatibility between LLVM releases of the LLVM-style output. We'd want a release note in this case, to advise of both the JSON fix and the change in LLVM style.
https://github.com/llvm/llvm-project/pull/92835
More information about the llvm-commits
mailing list