[clang] [llvm] Disable compiling and testing Flang on Clang changes (PR #92740)
Mehdi Amini via llvm-commits
llvm-commits at lists.llvm.org
Mon May 20 10:38:31 PDT 2024
================
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
----------------
joker-eph wrote:
> That's not a Windows problem
I'm confused, nothing you wrote is a rebuttal of what I wrote...
Are you just arguing about terminology here? What if we replace every instance of "Windows problem" with "Testing the monorepo on Windows"?
> Claiming it is a Windows problem makes it sound like the issue is with the OS when that's not actually (known to be) the case.
It's not productive to try to finger point the "fault" to either the OS or the tests themselves or the infra or....
The problem that led us here is "Flang testing is hanging on the Windows CI agent for 20min unnecessarily".
The CI problem is specific to our testing on Windows?
> If you wish to block the PR from landing, please hit Request Changes and explain what you want to see done in order to move the PR forward in a timely manner.
I shouldn't have to hit "request change": there is an open discussion here that should be resolved.
I asked here why aren't we just disabling this on Windows right now and I didn't get a convincing answer so far, I don't understand.
So I you want to move forward fast here is a proposal: split this PR in two, right now disable Flang dependency on windows only, and open an other PR to disable the Flang dependency on Linux as well, we can discuss there.
https://github.com/llvm/llvm-project/pull/92740
More information about the llvm-commits
mailing list