[llvm] [LoopUnroll] Ignore inlinable calls if unrolling is forced (PR #88149)
George Burgess IV via llvm-commits
llvm-commits at lists.llvm.org
Mon May 20 10:32:44 PDT 2024
gburgessiv wrote:
> also, isn't this still going to result in the remark getting printed in the pre-link optimization pipeline?
I only observed the remarks during LTO, so I'd assumed that the prelink pipeline has a way of bypassing these checks (which passes my smell test, at least, since it's reasonable to expect opts to be in an unfinished state after pre-link).
> I think we should treat the PrepareForLTO and the call heuristic as two separate issues and go back to the original PR, splitting out the PrepareForLTO change
Yeah, fixing the bug first SGTM.
> please move the issue being fixed from the commit title to the commit message like Fixes #88141, otherwise it's confusing with the PR number
Done
https://github.com/llvm/llvm-project/pull/88149
More information about the llvm-commits
mailing list