[llvm] [AMDGPU][LSV] Restrict large vectors in graphics (PR #92540)

Piotr Sobczak via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 08:02:35 PDT 2024


piotrAMD wrote:

> > > We definitely should not be using the OS as a hint on usage or to change any properties like this
> > 
> > 
> > Fine - would adding a flag be better?
> 
> Not really. It would be better to just unconditionally change this to be 128 for any of the global-like address spaces. Ultimately this hook is supposed to be a "give me this property", and the constant address spaces are a weak heuristic for using scalar instructions. The problem would be in the use context for this

Happy to change this to 128 for any of the global-like address spaces, although I'll probably split GLOBAL_ADDRESS to a separate patch.

https://github.com/llvm/llvm-project/pull/92540


More information about the llvm-commits mailing list