[llvm] [FileCheck] improve prefix validation (PR #92248)
Paul T Robinson via llvm-commits
llvm-commits at lists.llvm.org
Mon May 20 06:58:43 PDT 2024
================
@@ -2468,24 +2468,36 @@ FileCheckString::CheckDag(const SourceMgr &SM, StringRef Buffer,
static bool ValidatePrefixes(StringRef Kind, StringSet<> &UniquePrefixes,
ArrayRef<StringRef> SuppliedPrefixes) {
+ static const char *Suffixes[] = {"-NEXT", "-SAME", "-EMPTY", "-NOT",
+ "-COUNT", "-DAG", "-LABEL"};
+
----------------
pogo59 wrote:
There is a place that checks for some (but not all) cases of multiple suffixes. That place should use the same list of suffixes that this function does, that is, there should be one list that is shared between them. Ideally that other place would also be enhanced to check for all combinations, but that can wait for another patch.
https://github.com/llvm/llvm-project/pull/92248
More information about the llvm-commits
mailing list