[llvm] [RemoveDIs] Add a 'BeforeDbgRecords' parameter to C API isnt insertion functions (PR #92417)

[Orlando Cazalet-Hyams via llvm-commits]

OCHyams wrote:

Ok thanks for the clarifications and explanations. I'll make those changes to this patch and then follow up with a patch to fix my previous changes too.

> Yeah, this is not allowed :(
> I think what I'd do for the C API is to keep just the new functions you added for dbg records and remove the old functions for intrinsics. Keeping the old name around and making it create intrinsics would be too much of a footgun. And I don't think that we actually need support for the old format in the C API.

For the intrinsic-inserting functions, do you think we should:
a) mark as deprecated but otherwise leave them alone for now
b) mark as deprecated and change their behaviour so that they do nothing and return nullptr
c) outright delete them (it sounds like you're voting this one, but just wanted to double check)

https://github.com/llvm/llvm-project/pull/92417