[llvm] [nfc][InstrFDO]Encapsulate header writes in a class member function (PR #90142)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 13:40:13 PDT 2024


================
@@ -552,6 +552,29 @@ static Error writeMemProf(
               memprof::MaximumSupportedVersion));
 }
 
+uint64_t InstrProfWriter::writeHeader(const IndexedInstrProf::Header &Header,
+                                      const bool WritePrevVersion,
+                                      ProfOStream &OS) {
+  // Records the offset before writing any fields.
----------------
kazutakahirata wrote:

Use the infinitive form to be consistent with `Reserve the space ...` below.

```suggestion
  // Record the offset before writing any fields.
```

https://github.com/llvm/llvm-project/pull/90142


More information about the llvm-commits mailing list