[llvm] [SelectionDAG] Use ZERO_EXTEND_VECTOR_INREG for vectors (PR #92048)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 08:17:09 PDT 2024


================
@@ -1508,8 +1508,7 @@ SDValue DAGTypeLegalizer::PromoteIntRes_VPFunnelShift(SDNode *N) {
       !TLI.isOperationLegalOrCustom(Opcode, VT)) {
     SDValue HiShift = DAG.getConstant(OldBits, DL, VT);
     Hi = DAG.getNode(ISD::VP_SHL, DL, VT, Hi, HiShift, Mask, EVL);
-    // FIXME: Replace it by vp operations.
-    Lo = DAG.getZeroExtendInReg(Lo, DL, OldVT);
+    Lo = DAG.getNode(ISD::ZERO_EXTEND_VECTOR_INREG, DL, VT, Lo);
----------------
topperc wrote:

It isn't correct and this isn't a VP instruction so wouldn't address the FIXME. The FIXME was saying we should use ISD::VP_AND instead of ISD::AND

https://github.com/llvm/llvm-project/pull/92048


More information about the llvm-commits mailing list