[lld] [LLD] Implement --enable-non-contiguous-regions (PR #90007)

Daniel Thornburgh via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 16:32:10 PDT 2024


================
@@ -226,6 +226,8 @@ void OutputSection::finalizeInputSections() {
         i = std::prev(mergeSections.end());
         syn->entsize = ms->entsize;
         isd->sections.push_back(syn);
+        if (script)
----------------
mysterymath wrote:

> `script` is always non-null, so you can pass a reference

This is also used in writeARMCmseImportLib. It didn't seem like there would be any overlap between that and the SHF_MERGE case here, so that invocation is left null. Admittedly I have very little idea what CMSE is or what that function is doing; if this is more relevant than my intuition suggested, please let me know.

https://github.com/llvm/llvm-project/pull/90007


More information about the llvm-commits mailing list