[llvm] [BOLT][NFC] Simplify FuncHashesTy (PR #91815)
via llvm-commits
llvm-commits at lists.llvm.org
Fri May 10 14:45:50 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-bolt
Author: Amir Ayupov (aaupov)
<details>
<summary>Changes</summary>
Make EntryTy a thin wrapper struct.
---
Full diff: https://github.com/llvm/llvm-project/pull/91815.diff
1 Files Affected:
- (modified) bolt/include/bolt/Profile/BoltAddressTranslation.h (+5-10)
``````````diff
diff --git a/bolt/include/bolt/Profile/BoltAddressTranslation.h b/bolt/include/bolt/Profile/BoltAddressTranslation.h
index 68b993ee363cc..2996e3a2188c3 100644
--- a/bolt/include/bolt/Profile/BoltAddressTranslation.h
+++ b/bolt/include/bolt/Profile/BoltAddressTranslation.h
@@ -221,14 +221,9 @@ class BoltAddressTranslation {
/// Map function output address to its hash and basic blocks hash map.
class FuncHashesTy {
- class EntryTy {
+ struct EntryTy {
size_t Hash;
BBHashMapTy BBHashMap;
-
- public:
- size_t getBFHash() const { return Hash; }
- const BBHashMapTy &getBBHashMap() const { return BBHashMap; }
- EntryTy(size_t Hash) : Hash(Hash) {}
};
std::unordered_map<uint64_t, EntryTy> Map;
@@ -240,15 +235,15 @@ class BoltAddressTranslation {
public:
size_t getBFHash(uint64_t FuncOutputAddress) const {
- return getEntry(FuncOutputAddress).getBFHash();
+ return getEntry(FuncOutputAddress).Hash;
}
const BBHashMapTy &getBBHashMap(uint64_t FuncOutputAddress) const {
- return getEntry(FuncOutputAddress).getBBHashMap();
+ return getEntry(FuncOutputAddress).BBHashMap;
}
void addEntry(uint64_t FuncOutputAddress, size_t BFHash) {
- Map.emplace(FuncOutputAddress, EntryTy(BFHash));
+ Map.emplace(FuncOutputAddress, EntryTy{BFHash, BBHashMapTy()});
}
size_t getNumFunctions() const { return Map.size(); };
@@ -256,7 +251,7 @@ class BoltAddressTranslation {
size_t getNumBasicBlocks() const {
size_t NumBasicBlocks{0};
for (auto &I : Map)
- NumBasicBlocks += I.second.getBBHashMap().getNumBasicBlocks();
+ NumBasicBlocks += I.second.BBHashMap.getNumBasicBlocks();
return NumBasicBlocks;
}
};
``````````
</details>
https://github.com/llvm/llvm-project/pull/91815
More information about the llvm-commits
mailing list