[lld] [LLD] Implement --enable-non-contiguous-regions (PR #90007)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 14:25:47 PDT 2024


================
@@ -1364,6 +1436,117 @@ const Defined *LinkerScript::assignAddresses() {
   return getChangedSymbolAssignment(oldValues);
 }
 
+static bool hasRegionOverflowed(MemoryRegion *mr) {
+  if (!mr)
+    return false;
+  return mr->curPos - mr->getOrigin() > mr->getLength();
+}
+
+// Spill input sections in reverse order of address assignment to (potentially)
+// bring memory regions out of overflow. The size savings of a spill can only be
+// estimated, since general linker script arithmetic may occur afterwards.
+// Under-estimates may cause unnecessary spills, but over-estimates can always
+// be corrected on the next pass.
+bool LinkerScript::spillSections() {
+  if (!config->enableNonContiguousRegions)
+    return false;
+
+  bool spilled = false;
+  for (SectionCommand *cmd : reverse(sectionCommands)) {
+    auto *od = dyn_cast<OutputDesc>(cmd);
+    if (!od)
+      continue;
+    OutputSection *osec = &od->osec;
+    if (!osec->size || !osec->memRegion)
----------------
MaskRay wrote:

`!osec->size` is unnecessary. We try to remove unneeded conditions for code with no performance impact.

https://github.com/llvm/llvm-project/pull/90007


More information about the llvm-commits mailing list