[llvm] 331f22a - [AMDGPU] Remove unnecessary predicates from aliases. NFC. (#91602)

via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 07:04:41 PDT 2024


Author: Jay Foad
Date: 2024-05-10T15:04:38+01:00
New Revision: 331f22af4b4c849a97c97e6803e0c8cab57fa10b

URL: https://github.com/llvm/llvm-project/commit/331f22af4b4c849a97c97e6803e0c8cab57fa10b
DIFF: https://github.com/llvm/llvm-project/commit/331f22af4b4c849a97c97e6803e0c8cab57fa10b.diff

LOG: [AMDGPU] Remove unnecessary predicates from aliases. NFC. (#91602)

So long as the target of the alias is predicated with HasImageInsts or
similar, the alias itself does not need this predicate.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/EXPInstructions.td
    llvm/lib/Target/AMDGPU/MIMGInstructions.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/EXPInstructions.td b/llvm/lib/Target/AMDGPU/EXPInstructions.td
index e02652e62a574..5e426b5acd50d 100644
--- a/llvm/lib/Target/AMDGPU/EXPInstructions.td
+++ b/llvm/lib/Target/AMDGPU/EXPInstructions.td
@@ -125,7 +125,6 @@ multiclass VEXPORT_Real_gfx12 {
   }
   def : AMDGPUMnemonicAlias<"exp", "export"> {
     let AssemblerPredicate = isGFX12Plus;
-    let OtherPredicates = [HasExportInsts];
   }
 }
 

diff  --git a/llvm/lib/Target/AMDGPU/MIMGInstructions.td b/llvm/lib/Target/AMDGPU/MIMGInstructions.td
index 9f6277f1257f7..351263d079768 100644
--- a/llvm/lib/Target/AMDGPU/MIMGInstructions.td
+++ b/llvm/lib/Target/AMDGPU/MIMGInstructions.td
@@ -1079,7 +1079,6 @@ multiclass MIMG_Atomic_Addr_Helper_m <mimgopc op, string asm,
   if !and(op.HAS_GFX12, !not(!empty(renamed))) then
     def : AMDGPUMnemonicAlias<asm, renamed> {
       let AssemblerPredicate = isGFX12Plus;
-      let OtherPredicates = [HasImageInsts];
       bit IsAtomicRet; // Unused
       MIMGBaseOpcode BaseOpcode; // Unused
       int VDataDwords; // Unused


        


More information about the llvm-commits mailing list