[llvm] [X86][CodeGen] Return true when MIR is changed after optimizeCompareInstr (PR #91723)

Shengchen Kan via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 03:43:59 PDT 2024


https://github.com/KanRobert created https://github.com/llvm/llvm-project/pull/91723

This fixes the typo in 1be131ba275b


>From e28596be7a6b8ae1616b96278331b74566d7ca00 Mon Sep 17 00:00:00 2001
From: Shengchen Kan <shengchen.kan at intel.com>
Date: Fri, 10 May 2024 18:41:10 +0800
Subject: [PATCH] [X86][CodeGen] Return true when MIR is changed after
 optimizeCompareInstr

This fixes the typo in 1be131ba275b
---
 llvm/lib/Target/X86/X86InstrInfo.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/Target/X86/X86InstrInfo.cpp b/llvm/lib/Target/X86/X86InstrInfo.cpp
index 0e5e52d4d88e8..d7641f5f48fd6 100644
--- a/llvm/lib/Target/X86/X86InstrInfo.cpp
+++ b/llvm/lib/Target/X86/X86InstrInfo.cpp
@@ -5169,7 +5169,7 @@ bool X86InstrInfo::optimizeCompareInstr(MachineInstr &CmpInstr, Register SrcReg,
     // Fall through to optimize Cmp if Cmp is CMPrr or CMPri.
     if (NewOpcode == X86::CMP64rm || NewOpcode == X86::CMP32rm ||
         NewOpcode == X86::CMP16rm || NewOpcode == X86::CMP8rm)
-      return false;
+      return true;
   }
   }
 



More information about the llvm-commits mailing list