[llvm] [SPIR-V] Support saturation arithmetic intrinsics in SPIR-V Backend (PR #91722)
via llvm-commits
llvm-commits at lists.llvm.org
Fri May 10 03:15:20 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-spir-v
Author: Vyacheslav Levytskyy (VyacheslavLevytskyy)
<details>
<summary>Changes</summary>
This PR is to support saturation arithmetic intrinsics in SPIR-V Backend.
---
Full diff: https://github.com/llvm/llvm-project/pull/91722.diff
3 Files Affected:
- (modified) llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp (+9)
- (modified) llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp (+4)
- (added) llvm/test/CodeGen/SPIRV/llvm-intrinsics/satur-arith.ll (+19)
``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
index 2051cdc7e01ff..517a9b490ebad 100644
--- a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
@@ -495,6 +495,15 @@ bool SPIRVInstructionSelector::spvSelect(Register ResVReg,
case TargetOpcode::G_UMULH:
return selectExtInst(ResVReg, ResType, I, CL::u_mul_hi);
+ case TargetOpcode::G_SADDSAT:
+ return selectExtInst(ResVReg, ResType, I, CL::s_add_sat);
+ case TargetOpcode::G_UADDSAT:
+ return selectExtInst(ResVReg, ResType, I, CL::u_add_sat);
+ case TargetOpcode::G_SSUBSAT:
+ return selectExtInst(ResVReg, ResType, I, CL::s_sub_sat);
+ case TargetOpcode::G_USUBSAT:
+ return selectExtInst(ResVReg, ResType, I, CL::u_sub_sat);
+
case TargetOpcode::G_SEXT:
return selectExt(ResVReg, ResType, I, true);
case TargetOpcode::G_ANYEXT:
diff --git a/llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp b/llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp
index e7b35555293a3..42d36fd30ed6f 100644
--- a/llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp
@@ -304,6 +304,10 @@ SPIRVLegalizerInfo::SPIRVLegalizerInfo(const SPIRVSubtarget &ST) {
// Struct return types become a single scalar, so cannot easily legalize.
getActionDefinitionsBuilder({G_SMULH, G_UMULH}).alwaysLegal();
+
+ // supported saturation arithmetic
+ getActionDefinitionsBuilder({G_SADDSAT, G_UADDSAT, G_SSUBSAT, G_USUBSAT})
+ .legalFor(allIntScalarsAndVectors);
}
getLegacyLegalizerInfo().computeTables();
diff --git a/llvm/test/CodeGen/SPIRV/llvm-intrinsics/satur-arith.ll b/llvm/test/CodeGen/SPIRV/llvm-intrinsics/satur-arith.ll
new file mode 100644
index 0000000000000..8471e03958409
--- /dev/null
+++ b/llvm/test/CodeGen/SPIRV/llvm-intrinsics/satur-arith.ll
@@ -0,0 +1,19 @@
+; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+
+; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+
+; CHECK: %[[#]] = OpExtInst %[[#]] %[[#]] u_add_sat
+; CHECK-NEXT: %[[#]] = OpExtInst %[[#]] %[[#]] u_sub_sat
+; CHECK-NEXT: %[[#]] = OpExtInst %[[#]] %[[#]] s_add_sat
+; CHECK-NEXT: %[[#]] = OpExtInst %[[#]] %[[#]] s_sub_sat
+
+define spir_func void @foo(i16 %x, i16 %y) {
+entry:
+ %r1 = tail call i16 @llvm.uadd.sat.i16(i16 %x, i16 %y)
+ %r2 = tail call i16 @llvm.usub.sat.i16(i16 %x, i16 %y)
+ %r3 = tail call i16 @llvm.sadd.sat.i16(i16 %x, i16 %y)
+ %r4 = tail call i16 @llvm.ssub.sat.i16(i16 %x, i16 %y)
+ ret void
+}
``````````
</details>
https://github.com/llvm/llvm-project/pull/91722
More information about the llvm-commits
mailing list