[llvm] e7e13c6 - [ORC] Fix another error fall-through in EPCGenericDylibManager::lookupAsync.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 23:21:10 PDT 2024


Author: Lang Hames
Date: 2024-05-10T16:21:01+10:00
New Revision: e7e13c6ffec58fe67a23d173387e96d5ebb8f84b

URL: https://github.com/llvm/llvm-project/commit/e7e13c6ffec58fe67a23d173387e96d5ebb8f84b
DIFF: https://github.com/llvm/llvm-project/commit/e7e13c6ffec58fe67a23d173387e96d5ebb8f84b.diff

LOG: [ORC] Fix another error fall-through in EPCGenericDylibManager::lookupAsync.

The early return added in this commit should have been added in cbf1535cc81.

No test-case: This would require a deliberately injected failure in a
remote-JIT test and we don't have the infrastructure for that at the moment.

rdar://126772381

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/Orc/EPCGenericDylibManager.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/Orc/EPCGenericDylibManager.cpp b/llvm/lib/ExecutionEngine/Orc/EPCGenericDylibManager.cpp
index 7c0d890129229..298bde46ab754 100644
--- a/llvm/lib/ExecutionEngine/Orc/EPCGenericDylibManager.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/EPCGenericDylibManager.cpp
@@ -92,6 +92,7 @@ void EPCGenericDylibManager::lookupAsync(tpctypes::DylibHandle H,
         if (SerializationErr) {
           cantFail(Result.takeError());
           Complete(std::move(SerializationErr));
+          return;
         }
         Complete(std::move(Result));
       },


        


More information about the llvm-commits mailing list