[llvm] 06ad863 - [NFC] Prefer `str.resize(len)` over `str.substr(0, len)` (#91067)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 22:56:40 PDT 2024


Author: Danny Mösch
Date: 2024-05-10T07:56:35+02:00
New Revision: 06ad86361ab29d344a5e2e22903c2739743c77be

URL: https://github.com/llvm/llvm-project/commit/06ad86361ab29d344a5e2e22903c2739743c77be
DIFF: https://github.com/llvm/llvm-project/commit/06ad86361ab29d344a5e2e22903c2739743c77be.diff

LOG: [NFC] Prefer `str.resize(len)` over `str.substr(0, len)` (#91067)

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/DOTGraphTraitsPass.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h b/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
index da72fb511f82d..7aea7a3b0f6d6 100644
--- a/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
+++ b/llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
@@ -87,13 +87,12 @@ struct DOTGraphTraitsViewer
 };
 
 static inline void shortenFileName(std::string &FN, unsigned char len = 250) {
-
-  FN = FN.substr(0, len);
-
+  if (FN.length() > len)
+    FN.resize(len);
   auto strLen = FN.length();
   while (strLen > 0) {
-    if (auto it = nameObj.find(FN); it != nameObj.end()) {
-      FN = FN.substr(0, --len);
+    if (nameObj.find(FN) != nameObj.end()) {
+      FN.resize(--len);
     } else {
       nameObj.insert(FN);
       break;


        


More information about the llvm-commits mailing list