[llvm] [DebugInfo][JumpThreading] Fix missing debug location updates (PR #91581)

Shan Huang via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 19:26:54 PDT 2024


================
@@ -1278,9 +1278,12 @@ bool JumpThreadingPass::simplifyPartiallyRedundantLoad(LoadInst *LoadI) {
     // only happen in dead loops.
     if (AvailableVal == LoadI)
       AvailableVal = PoisonValue::get(LoadI->getType());
-    if (AvailableVal->getType() != LoadI->getType())
+    if (AvailableVal->getType() != LoadI->getType()) {
       AvailableVal = CastInst::CreateBitOrPointerCast(
           AvailableVal, LoadI->getType(), "", LoadI->getIterator());
+      if (Instruction *CI = dyn_cast<Instruction>(AvailableVal))
+        CI->setDebugLoc(LoadI->getDebugLoc());
----------------
Apochens wrote:

@OCHyams  I have tried `check-llvm`, `check-all` and `check-llvm-unit`, resulting no test triggering the assertion (even if I move the assertion out of the `then` branch).

https://github.com/llvm/llvm-project/pull/91581


More information about the llvm-commits mailing list