[llvm] [AMDGPU] Remove unnecessary predicates from aliases. NFC. (PR #91602)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Thu May 9 13:13:33 PDT 2024
https://github.com/jayfoad updated https://github.com/llvm/llvm-project/pull/91602
>From 460b0e323494c08e9a099fe2c4f90c4a9fd8bd2f Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Thu, 9 May 2024 15:47:24 +0100
Subject: [PATCH] [AMDGPU] Remove unnecessary predicates from aliases. NFC.
So long as the target of the alias is predicated with HasImageInsts or
similar, the alias itself does not need this predicate.
---
llvm/lib/Target/AMDGPU/EXPInstructions.td | 1 -
llvm/lib/Target/AMDGPU/MIMGInstructions.td | 1 -
2 files changed, 2 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/EXPInstructions.td b/llvm/lib/Target/AMDGPU/EXPInstructions.td
index e02652e62a574..5e426b5acd50d 100644
--- a/llvm/lib/Target/AMDGPU/EXPInstructions.td
+++ b/llvm/lib/Target/AMDGPU/EXPInstructions.td
@@ -125,7 +125,6 @@ multiclass VEXPORT_Real_gfx12 {
}
def : AMDGPUMnemonicAlias<"exp", "export"> {
let AssemblerPredicate = isGFX12Plus;
- let OtherPredicates = [HasExportInsts];
}
}
diff --git a/llvm/lib/Target/AMDGPU/MIMGInstructions.td b/llvm/lib/Target/AMDGPU/MIMGInstructions.td
index 9f6277f1257f7..351263d079768 100644
--- a/llvm/lib/Target/AMDGPU/MIMGInstructions.td
+++ b/llvm/lib/Target/AMDGPU/MIMGInstructions.td
@@ -1079,7 +1079,6 @@ multiclass MIMG_Atomic_Addr_Helper_m <mimgopc op, string asm,
if !and(op.HAS_GFX12, !not(!empty(renamed))) then
def : AMDGPUMnemonicAlias<asm, renamed> {
let AssemblerPredicate = isGFX12Plus;
- let OtherPredicates = [HasImageInsts];
bit IsAtomicRet; // Unused
MIMGBaseOpcode BaseOpcode; // Unused
int VDataDwords; // Unused
More information about the llvm-commits
mailing list