[llvm] [x86] Add tan intrinsic part 4 (PR #90503)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 08:26:51 PDT 2024


================
@@ -6706,6 +6707,9 @@ void SelectionDAGBuilder::visitIntrinsicCall(const CallInst &I,
     case Intrinsic::fabs:      Opcode = ISD::FABS;       break;
     case Intrinsic::sin:       Opcode = ISD::FSIN;       break;
     case Intrinsic::cos:       Opcode = ISD::FCOS;       break;
+    case Intrinsic::tan:
+      Opcode = ISD::FTAN;
+      break;
----------------
arsenm wrote:

I think we need to fix this once and for all by turning all of these horrible case, assign, break patterns into separate helper functions that just return the value. This happens on every DAG opcode patch 

https://github.com/llvm/llvm-project/pull/90503


More information about the llvm-commits mailing list