[llvm] [DebugInfo][JumpThreading] Fix missing debug location updates (PR #91581)

Orlando Cazalet-Hyams via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 06:10:42 PDT 2024


================
@@ -0,0 +1,98 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
----------------
OCHyams wrote:

Is this true - it looks like there are additional checks you've added by hand (at least the `DBG29` check)?

If someone came along and regenerated the checks using update_test_checks.py I'm worried we'd lose the ones you added (I'm not super familiar with  update_test_checks.py - maybe you could check this out?).

As an aside, I'm not sure we need to check each instruction here either, just enough to be sure the transformation has happened - possibly it would be enough to just check the `.exit.thread4:` block contents?

https://github.com/llvm/llvm-project/pull/91581


More information about the llvm-commits mailing list