[llvm] [NVPTX] support immediate values in st.param instructions (PR #91523)

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 14:59:49 PDT 2024


================
@@ -2182,6 +2182,84 @@ bool NVPTXDAGToDAGISel::tryStoreRetval(SDNode *N) {
   return true;
 }
 
+// Helpers for constructing opcode (ex: NVPTX::StoreParamV4F32_iiri)
+#define getOpcV2H(ty, op0, op1) NVPTX::StoreParamV2##ty##_##op0##op1
----------------
Artem-B wrote:

The argument naming structure is a bit confusing. 
In some places like here `opN` are  `i` and `r` tokens to be glued together. 
In others `opN` are apparently values that are used in comparisons.

Perhaps give them distinct names (opKindN/isImmN ?)

https://github.com/llvm/llvm-project/pull/91523


More information about the llvm-commits mailing list