[llvm] [NFC] Apply absorption rule to boolean expression (PR #91540)

via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 14:54:45 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-bolt

Author: Danny Mösch (SimplyDanny)

<details>
<summary>Changes</summary>

Fixes #<!-- -->91197.

---
Full diff: https://github.com/llvm/llvm-project/pull/91540.diff


1 Files Affected:

- (modified) bolt/include/bolt/Passes/IndirectCallPromotion.h (+1-1) 


``````````diff
diff --git a/bolt/include/bolt/Passes/IndirectCallPromotion.h b/bolt/include/bolt/Passes/IndirectCallPromotion.h
index adc58d70ec0f..8ec160b867cf 100644
--- a/bolt/include/bolt/Passes/IndirectCallPromotion.h
+++ b/bolt/include/bolt/Passes/IndirectCallPromotion.h
@@ -104,7 +104,7 @@ class IndirectCallPromotion : public BinaryFunctionPass {
   struct Location {
     MCSymbol *Sym{nullptr};
     uint64_t Addr{0};
-    bool isValid() const { return Sym || (!Sym && Addr != 0); }
+    bool isValid() const { return Sym || Addr != 0; }
     Location() {}
     explicit Location(MCSymbol *Sym) : Sym(Sym) {}
     explicit Location(uint64_t Addr) : Addr(Addr) {}

``````````

</details>


https://github.com/llvm/llvm-project/pull/91540


More information about the llvm-commits mailing list