[compiler-rt] [Sanitizers] Fix fake_test_gc not working on devices (PR #91284)

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 12:07:47 PDT 2024


yln wrote:

Almost all tests in `compiler-rt/test/asan` use `not %run`.  I only see these 2 using the other order, so this change should be fine as long as it preserves the intended behavior:
```
compiler-rt/test/asan/TestCases/pass-object-byval.cpp:
  3  // RUN: %clangxx_asan -O0 %s -o %t
  4: // RUN: not %run %t 2>&1 | FileCheck %s --implicit-check-not \
  5  // RUN:     Assertion{{.*}}failed

compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp:
  1: // RUN: %clangxx_asan -O0 -pthread %s -o %t && %env_asan_opts=use_sigaltstack=0 %run not --crash %t 2>&1 | FileCheck %s
  2  
```

@wrotki can you do a quick sanity check for the other ASan test `pass-object-byval.cpp`?  Do we execute it (on-device)?  Does it work?  Should it get the same treatment?

https://github.com/llvm/llvm-project/pull/91284


More information about the llvm-commits mailing list