[lld] [llvm] [Symbolizer] Support for Missing Line Numbers. (PR #82240)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 12:33:15 PDT 2024


================
@@ -427,6 +429,9 @@ class DWARFDebugLine {
   using LineTableConstIter = LineTableMapTy::const_iterator;
 
   LineTableMapTy LineTableMap;
+
+public:
+  inline static bool ReportApproximateLine = false;
----------------
dwblaikie wrote:

mutable `static` variables are concerning - that makes the code not thread safe/re-entrant, etc.

Please don't do this - and pass down the request through some parameter/non-static member state. (we have other parameters for line queries, perhaps this can be bundled along with those, or as an optional parameter)

https://github.com/llvm/llvm-project/pull/82240


More information about the llvm-commits mailing list