[llvm] [InstCombine] Remove some of the complexity-based canonicalization (PR #91185)
via llvm-commits
llvm-commits at lists.llvm.org
Tue May 7 11:35:27 PDT 2024
goldsteinn wrote:
> > > > Can you run it? Ill try and get -stats to work locally and post them here.
> > >
> > >
> > > I cannot run it as LLVM doesn't support the cost estimation of struct types :(
> >
> >
> > Err misunderstanding, I mean can you just generate your normal diffs. Ill do the cost estimation stuff locally and just post the results here.
>
> Done. The IR diff basically looks fine to me.
>
> The main problem is that some `icmp pred A, B` and `icmp swap(pred) B, A` pairs are not CSEed now. See [dtcxzyw/llvm-opt-benchmark#583 (comment)](https://github.com/dtcxzyw/llvm-opt-benchmark/pull/583#discussion_r1591786430).
>
Ah, truthfully that and commutative binops imo make a case for keeping this as is.
https://github.com/llvm/llvm-project/pull/91185
More information about the llvm-commits
mailing list