[llvm] [AMDGPU] Disallow negative s_load offsets in isLegalAddressingMode (PR #91327)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 07:05:09 PDT 2024


================
@@ -1604,6 +1604,14 @@ bool SITargetLowering::isLegalAddressingMode(const DataLayout &DL,
         return false;
     }
 
+    if (AS == AMDGPUAS::CONSTANT_ADDRESS && AM.BaseOffs < 0) {
----------------
jayfoad wrote:

I specifically didn't want to include constant_32bit because I saw a case where LLPC was using that address space for an s_buffer_load, not an s_load. But I did not look into _why_ that was happening. I have never understood constant_32bit.

https://github.com/llvm/llvm-project/pull/91327


More information about the llvm-commits mailing list