[compiler-rt] [Sanitizers] Fix fake_test_gc not working on devices (PR #91284)

via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 17:02:19 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Mariusz Borsa (wrotki)

<details>
<summary>Changes</summary>

The way the LIT RUN command is currently constructed ( %run not --crash %t ) causes the test failure on devices - since 'not' is a LLVM built command, not available on devices.

Changing the command to read 'not --crash %run %t' fixes it, as 'not' now executes on the host running the test.

rdar://115914588


---
Full diff: https://github.com/llvm/llvm-project/pull/91284.diff


1 Files Affected:

- (modified) compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp (+1-1) 


``````````diff
diff --git a/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp b/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp
index 524ca29f2fc577..8c368b9b1b947f 100644
--- a/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/fake_stack_gc.cpp
@@ -1,4 +1,4 @@
-// RUN: %clangxx_asan -O0 -pthread %s -o %t && %env_asan_opts=use_sigaltstack=0 %run not --crash %t 2>&1 | FileCheck %s
+// RUN: %clangxx_asan -O0 -pthread %s -o %t && %env_asan_opts=use_sigaltstack=0 not --crash %run %t 2>&1 | FileCheck %s
 
 // Check that fake stack does not discard frames on the main stack, when GC is
 // triggered from high alt stack.

``````````

</details>


https://github.com/llvm/llvm-project/pull/91284


More information about the llvm-commits mailing list