[llvm] [coro][CoroSplit] Use `llvm.lifetime.end` to compute putting objects on the frame vs the stack (PR #90265)

via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 09:04:50 PDT 2024


================
@@ -96,6 +96,22 @@ bool isPotentiallyReachableFromMany(
     const SmallPtrSetImpl<BasicBlock *> *ExclusionSet,
     const DominatorTree *DT = nullptr, const LoopInfo *LI = nullptr);
 
+/// Determine whether there is at least one path from a block in
+/// 'Worklist' to a block in 'StopSet' without passing through any
+///  blocks in 'ExclusionSet', returning true if uncertain.
----------------
zmodem wrote:

I think you removed the comment for line 88-93 instead (or github is making things look funny). I didn't realize the original function also had this redundancy. In any case, it seems weird to have double "Determine whether ..." comments for each functions. But fixing that could perhaps be done in a separate cleanup commit.

https://github.com/llvm/llvm-project/pull/90265


More information about the llvm-commits mailing list