[llvm] [AMDGPU] Enhance s_waitcnt insertion before barrier for gfx12 (PR #90595)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 05:02:01 PDT 2024


================
@@ -1386,6 +1386,14 @@ class SIInstrInfo final : public AMDGPUGenInstrInfo {
   // This is used if an operand is a 32 bit register but needs to be aligned
   // regardless.
   void enforceOperandRCAlignment(MachineInstr &MI, unsigned OpName) const;
+
+  bool isBarrierStart(uint16_t Opcode) const {
----------------
jayfoad wrote:

Nits: should really have a function comment. Also there are load of other `is` predicates in this file, finishing around line 920. Maybe move this up there with them?

https://github.com/llvm/llvm-project/pull/90595


More information about the llvm-commits mailing list