[llvm] [AArch64][GlobalISel] Select G_ICMP Zero Instruction (PR #90054)

David Green via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 09:44:39 PDT 2024


davemgreen wrote:

> Is there any effect on SDAG codegen? If so then we can keep it in InstrInfo but if these new patterns only influence GlobalISel then I think it makes sense to separate them to avoid confusion about their purpose.

Hi - I'm not sure if it is best to keep them separate, and continue treating GlobalISel as a special thing that is off in its own corner. It feels better in the long run to treat these as standard patterns, put where they belong compared to all the other instructions. They should probably be documented that they apply to GISel to keep it clear, and my opinions on this are not very strongly held.  #89932 is probably the best place to mention if you think having the patterns separate is better.

https://github.com/llvm/llvm-project/pull/90054


More information about the llvm-commits mailing list