[compiler-rt] [compiler-rt][CMake] Do not explicitly set CMP0114 to old (PR #90386)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 28 01:52:47 PDT 2024


https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/90386

This was added in def0823f1d2db78c4a18b15084407734a45e96c5 to fix a bot failure, specifically for the standalone build. This does not seem to be an issue anymore, and setting the policy explicitly to OLD causes warnings with newer CMake versions.

This patch removes setting the policy to OLD to get rid of the warning.

>From 725b808249e79c4c7a42c32e4e6fcb782e57536a Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Sun, 28 Apr 2024 08:41:05 +0000
Subject: [PATCH] [compiler-rt][CMake] Do not explicitly set CMP0114 to old

This was added in def0823f1d2db78c4a18b15084407734a45e96c5 to fix a bot
failure, specifically for the standalone build. This does not seem to
be an issue anymore, and setting the policy explicitly to OLD causes
warnings with newer CMake versions.

This patch removes setting the policy to OLD to get rid of the warning.
---
 compiler-rt/cmake/Modules/AddCompilerRT.cmake | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/compiler-rt/cmake/Modules/AddCompilerRT.cmake b/compiler-rt/cmake/Modules/AddCompilerRT.cmake
index 6e0d9dbff65a9e..75b34c8e27e000 100644
--- a/compiler-rt/cmake/Modules/AddCompilerRT.cmake
+++ b/compiler-rt/cmake/Modules/AddCompilerRT.cmake
@@ -2,12 +2,6 @@ include(ExternalProject)
 include(CompilerRTUtils)
 include(HandleCompilerRT)
 
-# CMP0114: ExternalProject step targets fully adopt their steps.
-# New in CMake 3.19: https://cmake.org/cmake/help/latest/policy/CMP0114.html
-if(POLICY CMP0114)
-  cmake_policy(SET CMP0114 OLD)
-endif()
-
 function(set_target_output_directories target output_dir)
   # For RUNTIME_OUTPUT_DIRECTORY variable, Multi-configuration generators
   # append a per-configuration subdirectory to the specified directory.



More information about the llvm-commits mailing list