[llvm] [CMake] Do not set CMP0114 explicitly to old (PR #90384)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 28 01:34:28 PDT 2024


https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/90384

CMP0114 was originally set to old to get rid of warnings. However, this behavior is now set to new by default with the minimum CMake version that LLVM requires so does not produce any warnings, and setting it explicitly to old does produce a warning in newer CMake versions. Due to these reasons, remove this check for now.

Splitting off from removing the CMP0116 check just in case something breaks.

Partially fixes #83727.

>From e477a6ddd2db57dc15b7fe1475ff6aa6f812bba7 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Sun, 28 Apr 2024 08:29:06 +0000
Subject: [PATCH] [CMake] Do not set CMP0114 explicitly to old

CMP0114 was originally set to old to get rid of warnings. However, this
behavior is now set to new by default with the minimum CMake version
that LLVM requires so does not produce any warnings,
and setting it explicitly to old does produce a warning in newer CMake
versions. Due to these reasons, remove this check for now.

Splitting off from removing the CMP0116 check just in case something
breaks.

Partially fixes #83727.
---
 cmake/Modules/CMakePolicy.cmake | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/cmake/Modules/CMakePolicy.cmake b/cmake/Modules/CMakePolicy.cmake
index 1c18c1810dae62..169e38505eb2c8 100644
--- a/cmake/Modules/CMakePolicy.cmake
+++ b/cmake/Modules/CMakePolicy.cmake
@@ -1,10 +1,5 @@
 # CMake policy settings shared between LLVM projects
 
-# CMP0114: ExternalProject step targets fully adopt their steps.
-# New in CMake 3.19: https://cmake.org/cmake/help/latest/policy/CMP0114.html
-if(POLICY CMP0114)
-  cmake_policy(SET CMP0114 OLD)
-endif()
 # CMP0116: Ninja generators transform `DEPFILE`s from `add_custom_command()`
 # New in CMake 3.20. https://cmake.org/cmake/help/latest/policy/CMP0116.html
 if(POLICY CMP0116)



More information about the llvm-commits mailing list