[llvm] llvm-rc: add support for MENU in DIALOG(EX) (PR #89409)

via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 27 09:10:46 PDT 2024


================
@@ -419,18 +419,18 @@ RCParser::parseSingleOptionalStatement(OptStmtType StmtsType) {
   if (TypeToken->equals_insensitive("VERSION"))
     return parseVersionStmt();
 
-  if (StmtsType != OptStmtType::BasicStmt) {
----------------
oltolm wrote:

Good catch, that was actually a bug I introduced, because `BasicStmt` does not mean `DIALOG`. That's the definition of the `enum`.
```
enum class OptStmtType { BasicStmt, DialogStmt, DialogExStmt };
```

The code already worked for both dialog types. I will fix it.

https://github.com/llvm/llvm-project/pull/89409


More information about the llvm-commits mailing list