[llvm] [memprof] Remove getFullSchema in MemProfTest.cpp (PR #90072)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 25 09:07:32 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-pgo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
This patch removes getFullSchema in MemProfTest.cpp in favor of
llvm::memprof::PortableMemInfoBlock::getFullSchema as they do exactly
the same thing.
---
Full diff: https://github.com/llvm/llvm-project/pull/90072.diff
1 Files Affected:
- (modified) llvm/unittests/ProfileData/MemProfTest.cpp (+3-11)
``````````diff
diff --git a/llvm/unittests/ProfileData/MemProfTest.cpp b/llvm/unittests/ProfileData/MemProfTest.cpp
index 7e00a80cacf933..5e72b3a11f8ed2 100644
--- a/llvm/unittests/ProfileData/MemProfTest.cpp
+++ b/llvm/unittests/ProfileData/MemProfTest.cpp
@@ -122,14 +122,6 @@ MATCHER_P4(FrameContains, FunctionName, LineOffset, Column, Inline, "") {
return false;
}
-MemProfSchema getFullSchema() {
- MemProfSchema Schema;
-#define MIBEntryDef(NameTag, Name, Type) Schema.push_back(Meta::Name);
-#include "llvm/ProfileData/MIBEntryDef.inc"
-#undef MIBEntryDef
- return Schema;
-}
-
TEST(MemProf, FillsValue) {
std::unique_ptr<MockSymbolizer> Symbolizer(new MockSymbolizer());
@@ -248,7 +240,7 @@ TEST(MemProf, PortableWrapper) {
/*dealloc_timestamp=*/2000, /*alloc_cpu=*/3,
/*dealloc_cpu=*/4);
- const auto Schema = getFullSchema();
+ const auto Schema = llvm::memprof::PortableMemInfoBlock::getFullSchema();
PortableMemInfoBlock WriteBlock(Info);
std::string Buffer;
@@ -271,7 +263,7 @@ TEST(MemProf, PortableWrapper) {
// Version0 and Version1 serialize IndexedMemProfRecord in the same format, so
// we share one test.
TEST(MemProf, RecordSerializationRoundTripVersion0And1) {
- const MemProfSchema Schema = getFullSchema();
+ const auto Schema = llvm::memprof::PortableMemInfoBlock::getFullSchema();
MemInfoBlock Info(/*size=*/16, /*access_count=*/7, /*alloc_timestamp=*/1000,
/*dealloc_timestamp=*/2000, /*alloc_cpu=*/3,
@@ -305,7 +297,7 @@ TEST(MemProf, RecordSerializationRoundTripVersion0And1) {
}
TEST(MemProf, RecordSerializationRoundTripVerion2) {
- const MemProfSchema Schema = getFullSchema();
+ const auto Schema = llvm::memprof::PortableMemInfoBlock::getFullSchema();
MemInfoBlock Info(/*size=*/16, /*access_count=*/7, /*alloc_timestamp=*/1000,
/*dealloc_timestamp=*/2000, /*alloc_cpu=*/3,
``````````
</details>
https://github.com/llvm/llvm-project/pull/90072
More information about the llvm-commits
mailing list