[clang] [llvm] [mlir] Fix mismatches between function parameter definitions and declarations (PR #89512)
Troy Butler via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 25 05:56:18 PDT 2024
Troy-Butler wrote:
> @Troy-Butler I started to do the merge, but I cancelled it for now because it seems that github mangles the email metadata:  (Note that I obscured your email address in this screenshot, but it can be found within the commits that you published.)
>
> * I'd guess that want to use your "real" email address as the Author of this commit -- that case you probably need to change your github account settings. (I don't know the exact details but IIRC you can toggle whether it will use your email address in your commits.) Ping me when you're ready and I'll check the merge again.
> * If you don't want to embed that email address into the LLVM git history, then I can merge the commit without the `Signed-off-by` and `Co-authored-by` lines that mention it. The address will remain on the internet (in this pull request), but it won't be part of the LLVM main branch.
Thank you for pointing that out. I don't have any issues with that email address being embedded in LLVM's git history - you can go ahead and commit. Thanks!
https://github.com/llvm/llvm-project/pull/89512
More information about the llvm-commits
mailing list