[llvm] [RISCV] Use SHL_ADD in remaining strength reduce cases for MUL (PR #89789)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 11:34:35 PDT 2024


preames wrote:

> > > > /home/dtcxzyw/llvm-codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:767:19: error: Variable not defined: 'riscv_shl_add'
> > > > def : Pat<(i64 (riscv_shl_add (and GPR:$rs1, 0xFFFFFFFF), (i64 i), GPR:$rs2)),
> > 
> > 
> > I can't reproduce this failure. I suspect you didn't use a recent enough ToT revision as the base of the patch.
> 
> Baseline: [c108653](https://github.com/llvm/llvm-project/commit/c1086532d4d5c0a261457dfb00e79fcb764e3d78)

As I said, too old.  This change depends on 03760ad09d49f74c026f0b5d41d982cad81c67d7 which is in ToT, and not in that revision.  

https://github.com/llvm/llvm-project/pull/89789


More information about the llvm-commits mailing list