[clang] [llvm] [CodeGen][i386] Move -mregparm storage earlier and fix Runtime calls (PR #89707)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 11:06:17 PDT 2024


================
@@ -4781,6 +4782,7 @@ CodeGenModule::CreateRuntimeFunction(llvm::FunctionType *FTy, StringRef Name,
         }
       }
       setDSOLocal(F);
+      markRegisterParameterAttributes(F);
----------------
efriedma-quic wrote:

This really shouldn't work this way: we should go through CodeGenModule::SetLLVMFunctionAttributes to get all the correct attributes for a function.  Unfortunately, that's a bit complicated in this context because you need to construct a CGFunctionInfo, and none of the callers currently do that.  Which might be more work than you really want...  CC @JonPsson1 @jdoerfert @jhuber6

https://github.com/llvm/llvm-project/pull/89707


More information about the llvm-commits mailing list