[llvm] [RISCV] Sync some repeated code into parseVTypeToken. NFC (PR #89694)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 22 18:15:54 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-risc-v
Author: Craig Topper (topperc)
<details>
<summary>Changes</summary>
Both calls to parseVTypeToken were proceeded by check for an Identifier token and a call to getIdentifier. Sync those into the parseVTypeToken to reduce repetition.
---
Full diff: https://github.com/llvm/llvm-project/pull/89694.diff
1 Files Affected:
- (modified) llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp (+9-14)
``````````diff
diff --git a/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp b/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
index d926ccdb59e19b..3f4a73ad89bf8a 100644
--- a/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
+++ b/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
@@ -117,7 +117,7 @@ class RISCVAsmParser : public MCTargetAsmParser {
ParseStatus parseDirective(AsmToken DirectiveID) override;
- bool parseVTypeToken(StringRef Identifier, VTypeState &State, unsigned &Sew,
+ bool parseVTypeToken(const AsmToken &Tok, VTypeState &State, unsigned &Sew,
unsigned &Lmul, bool &Fractional, bool &TailAgnostic,
bool &MaskAgnostic);
bool generateVTypeError(SMLoc ErrorLoc);
@@ -2125,10 +2125,15 @@ ParseStatus RISCVAsmParser::parseJALOffset(OperandVector &Operands) {
return parseImmediate(Operands);
}
-bool RISCVAsmParser::parseVTypeToken(StringRef Identifier, VTypeState &State,
+bool RISCVAsmParser::parseVTypeToken(const AsmToken &Tok, VTypeState &State,
unsigned &Sew, unsigned &Lmul,
bool &Fractional, bool &TailAgnostic,
bool &MaskAgnostic) {
+ if (Tok.isNot(AsmToken::Identifier))
+ return true;
+
+ StringRef Identifier = Tok.getIdentifier();
+
switch (State) {
case VTypeState_SEW:
if (!Identifier.consume_front("e"))
@@ -2187,24 +2192,14 @@ ParseStatus RISCVAsmParser::parseVTypeI(OperandVector &Operands) {
VTypeState State = VTypeState_SEW;
- if (getLexer().isNot(AsmToken::Identifier))
- return ParseStatus::NoMatch;
-
- StringRef Identifier = getTok().getIdentifier();
-
- if (parseVTypeToken(Identifier, State, Sew, Lmul, Fractional, TailAgnostic,
+ if (parseVTypeToken(getTok(), State, Sew, Lmul, Fractional, TailAgnostic,
MaskAgnostic))
return ParseStatus::NoMatch;
getLexer().Lex();
while (parseOptionalToken(AsmToken::Comma)) {
- if (getLexer().isNot(AsmToken::Identifier))
- break;
-
- Identifier = getTok().getIdentifier();
-
- if (parseVTypeToken(Identifier, State, Sew, Lmul, Fractional, TailAgnostic,
+ if (parseVTypeToken(getTok(), State, Sew, Lmul, Fractional, TailAgnostic,
MaskAgnostic))
break;
``````````
</details>
https://github.com/llvm/llvm-project/pull/89694
More information about the llvm-commits
mailing list