[llvm] [SystemZ][NFC] Use new getPointerSize function (PR #89623)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 22 09:22:04 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-systemz
Author: Kai Nacke (redstar)
<details>
<summary>Changes</summary>
Use the new getPointerSize() function throughout the frame lowering class.
---
Full diff: https://github.com/llvm/llvm-project/pull/89623.diff
1 Files Affected:
- (modified) llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp (+10-7)
``````````diff
diff --git a/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp b/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
index 2683470afc5edb..fa20977ec01877 100644
--- a/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
@@ -181,7 +181,8 @@ bool SystemZELFFrameLowering::assignCalleeSavedSpillSlots(
StartSPOffset = Offset;
}
Offset -= SystemZMC::ELFCallFrameSize;
- int FrameIdx = MFFrame.CreateFixedSpillStackObject(8, Offset);
+ int FrameIdx =
+ MFFrame.CreateFixedSpillStackObject(getPointerSize(), Offset);
CS.setFrameIdx(FrameIdx);
} else
CS.setFrameIdx(INT32_MAX);
@@ -456,8 +457,10 @@ void SystemZELFFrameLowering::processFunctionBeforeFrameFinalized(
// are outside the reach of an unsigned 12-bit displacement.
// Create 2 for the case where both addresses in an MVC are
// out of range.
- RS->addScavengingFrameIndex(MFFrame.CreateStackObject(8, Align(8), false));
- RS->addScavengingFrameIndex(MFFrame.CreateStackObject(8, Align(8), false));
+ RS->addScavengingFrameIndex(
+ MFFrame.CreateStackObject(getPointerSize(), Align(8), false));
+ RS->addScavengingFrameIndex(
+ MFFrame.CreateStackObject(getPointerSize(), Align(8), false));
}
// If R6 is used as an argument register it is still callee saved. If it in
@@ -870,7 +873,7 @@ int SystemZELFFrameLowering::getOrCreateFramePointerSaveIndex(
if (!FI) {
MachineFrameInfo &MFFrame = MF.getFrameInfo();
int Offset = getBackchainOffset(MF) - SystemZMC::ELFCallFrameSize;
- FI = MFFrame.CreateFixedObject(8, Offset, false);
+ FI = MFFrame.CreateFixedObject(getPointerSize(), Offset, false);
ZFI->setFramePointerSaveIndex(FI);
}
return FI;
@@ -906,7 +909,7 @@ int SystemZXPLINKFrameLowering::getOrCreateFramePointerSaveIndex(
int FI = ZFI->getFramePointerSaveIndex();
if (!FI) {
MachineFrameInfo &MFFrame = MF.getFrameInfo();
- FI = MFFrame.CreateFixedObject(8, 0, false);
+ FI = MFFrame.CreateFixedObject(getPointerSize(), 0, false);
MFFrame.setStackID(FI, TargetStackID::NoAlloc);
ZFI->setFramePointerSaveIndex(FI);
}
@@ -1032,7 +1035,7 @@ bool SystemZXPLINKFrameLowering::assignCalleeSavedSpillSlots(
// Non-volatile GPRs are saved in the dedicated register save area at
// the bottom of the stack and are not truly part of the "normal" stack
// frame. Mark the frame index as NoAlloc to indicate it as such.
- unsigned RegSize = 8;
+ unsigned RegSize = getPointerSize();
int FrameIdx =
(FPSI && Offset == 0)
? FPSI
@@ -1302,7 +1305,7 @@ void SystemZXPLINKFrameLowering::emitPrologue(MachineFunction &MF,
for (unsigned I = FixedRegs; I < SystemZ::XPLINK64NumArgGPRs; I++) {
uint64_t StartOffset = MFFrame.getOffsetAdjustment() +
MFFrame.getStackSize() + Regs.getCallFrameSize() +
- getOffsetOfLocalArea() + I * 8;
+ getOffsetOfLocalArea() + I * getPointerSize();
unsigned Reg = GPRs[I];
BuildMI(MBB, MBBI, DL, TII->get(SystemZ::STG))
.addReg(Reg)
``````````
</details>
https://github.com/llvm/llvm-project/pull/89623
More information about the llvm-commits
mailing list