ilovepi wrote: @MaskRay @asb Are we happy w/ this patch? I think I've addressed most of the concerns raised thus far, but I want try and finish the attributes patches this week if possible, since I'm back from EuroLLVM + vacation. https://github.com/llvm/llvm-project/pull/84597