[llvm] [SystemZ][z/OS] yaml2obj GOFF symbols (PR #75971)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 08:46:57 PDT 2024


================
@@ -245,6 +246,53 @@ void GOFFState::writeHeader(GOFFYAML::FileHeader &FileHdr) {
   }
 }
 
+void GOFFState::writeSymbol(GOFFYAML::Symbol Sym) {
+  SmallString<80> SymName;
+  if (std::error_code EC = ConverterEBCDIC::convertToEBCDIC(Sym.Name, SymName))
+    reportError("conversion error on " + Sym.Name + ": " + EC.message());
----------------
jh7370 wrote:

Coming back to this fresh, I think we can reword this:
```suggestion
    reportError("cannot convert '" + Sym.Name + "' to EBCDIC: " + EC.message());
```

You also should have a test case which triggers this error.

https://github.com/llvm/llvm-project/pull/75971


More information about the llvm-commits mailing list